New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove recursive write until its fixed #9519
Remove recursive write until its fixed #9519
Conversation
Yeah let's retarget this at 4.5. I'll do a separate patch to introduce it as a config when I'm ready. @silverstripe/core-team should my patch to reintroduce the config flag be 4.5 or 4.6? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this to 4.5
I feel like I'm missing something, it's already based off 4.5? |
@sminnee switched the branch for you. It's only showing one commit still but the builds will run against your branch, which is based off |
@adrhumphreys can you rebase onto 13b4d60 thanks |
@maxime-rainville do you think we should tidy this up before 4.6 gets to RC1? |
Sorry for the delay have made a new pr with it rebased here: #9528 Didn't want to rebase this branch as we've got a project using it currently ✌️ |
Cool yeah hopefully you can get https://github.com/cweagans/composer-patches in place for fast-tracking PRs into projects in the future, it's a bit less brittle and less prone to leaving projects stuck on fork.s |
As seen in the issue: silverstripe/silverstripe-assets#365
This will mean we need to reopen: #9162 as it would no longer be fixed
I feel like this could be targeted at the next release of 4.5 even