Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS add note to changelog for Solr changes #9576

Merged
merged 2 commits into from Jul 8, 2020
Merged

DOCS add note to changelog for Solr changes #9576

merged 2 commits into from Jul 8, 2020

Conversation

brynwhyman
Copy link
Contributor

I know we haven't quite landed on an approach for capturing information of non-core modules in changelogs, but I think this one is really worth including. Addons has the fulltextsearch module downloads at 158,435 and given the changes, I think it's better to be safe than sorry?

robbieaverill
robbieaverill reviewed Jul 6, 2020
View reviewed changes
docs/en/04_Changelogs/4.6.0.md Outdated Show resolved Hide resolved
docs/en/04_Changelogs/4.6.0.md Outdated Show resolved Hide resolved
docs/en/04_Changelogs/4.6.0.md Outdated Show resolved Hide resolved
docs/en/04_Changelogs/4.6.0.md Outdated Show resolved Hide resolved
docs/en/04_Changelogs/4.6.0.md Outdated Show resolved Hide resolved
DOCS add note to changelog for Solr changes
5647654 
I know we haven't quite landed on an approach for capturing information of non-core modules in changelogs, but I think this one is really worth including. Addons has the fulltextsearch module downloads at 158,435 and given the changes, I think it's better to be safe than sorry?
robbieaverill
robbieaverill reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not sure about putting satellite module changes in the core changelogs either, so I'll wait for someone else to make that determination.

dnsl48
dnsl48 approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@dnsl48 dnsl48 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I think at this point we just don't have a better place than the changelog to mention such impactful things.
Even though technically fulltext-search module is not a part of the CMS Recipes, I believe having that note in the changelog will do no harm.

Cheddam
Cheddam reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@Cheddam Cheddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor class typo, otherwise happy for this to go ahead (echoing @dnsl48's thoughts on the matter.)

docs/en/04_Changelogs/4.6.0.md Outdated Show resolved Hide resolved
DOCS fix typo
fd752ce 
Co-authored-by: Garion Herman <garion@silverstripe.com>
@maxime-rainville maxime-rainville merged commit 12a4c00 into silverstripe:4.6 Jul 8, 2020
@maxime-rainville maxime-rainville deleted the 4.6-changelog branch July 8, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheddam Cheddam Cheddam left review comments

@robbieaverill robbieaverill robbieaverill approved these changes

@dnsl48 dnsl48 dnsl48 approved these changes

Assignees
No one assigned
Labels
affects/v4 type/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brynwhyman @Cheddam @robbieaverill @dnsl48 @maxime-rainville