Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Expand Composer requirements to support PHP 8, Update Behat config to support Symfony 4 #9737

Merged
merged 2 commits into from Oct 16, 2020

Conversation

Cheddam
Copy link
Member

@Cheddam Cheddam commented Oct 15, 2020

PHP 8 support has been merged here and throughout the rest of core (barring the recipes themselves), so we're ready to flag this module as compatible with it. This PR also includes a tweak to Behat config to support symfony/yaml ^4.

Copy link
Contributor

@dnsl48 dnsl48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Cheddam Cheddam merged commit 45d0f1d into silverstripe:4 Oct 16, 2020
@Cheddam Cheddam deleted the pulls/4/php-8-support branch October 16, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants