DOCS replace broken Director link to Routing #9778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The full URL to the correct page is /en/4/developer_guides/controllers/routing/. Should the link here be /developer_guides/controllers/routing - i.e. is the relative link here relative to the developer_guides or the root?
cc @unclecheese
christopherdarling
force-pushed
the
patch-18
branch
from
52f1fbe
to
154fb70
Compare
Presumed those would be prefixed... I've swapped the link out for a relative link which seems to be the same way a few others on the page had been done |
|
Merging. If there's a bug in the docs gen, let's discuss that on the docs repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://docs.silverstripe.org/en/4/developer_guides/integration/csv_import/#import-through-a-custom-controller