NEW: Add phpstan level 1 analysis #9873
Conversation
This is a really simple level of phpstan execution, but can pass with a relative small commit.
| @@ -397,8 +397,6 @@ public function getViewer($action) | |||
| $templates = $this->templates[$action]; | |||
| } elseif (isset($this->templates['index']) && $this->templates['index']) { | |||
| $templates = $this->templates['index']; | |||
| } elseif ($this->template) { | |||
There was a problem hiding this comment.
This variable isn't defined. In theory people could define it in a subclass, but it's far from being a published API. This code goes back to the project's inception and I think it's an oversight.
In Security.php, private static $template is defined, which does not populate this variable - it's used as a config var. Notably, this code on PHP 7.4 failed to print HELLO
<?php
class A {
function foo() {
return $this->template;
}
}
class B extends A {
static $template = 'HELLO';
}
echo (new B())->foo();
In my view, removing this isn't a breaking change, but it's moderately controversial. As an alternative I would add a /** @phpstan-ignore-next-line */ flag; attempting to define template breaks other things.
| @@ -30,38 +30,7 @@ class DebugView | |||
| private static $columns = 100; | |||
|
|
|||
| protected static $error_types = [ | |||
| 0 => [ | |||
There was a problem hiding this comment.
These values aren't being used anywhere, only the errno-mapped ones are. And 2 conflicted with E_USER_WARNING
This is a really simple level of phpstan execution, but can pass with
a relatively small commit.
It will be included in the build if silverstripe/silverstripe-travis-shared#12 is merged (done)