Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Handle early versions of webonyx/graphql-php #489

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 22, 2022

Issue silverstripe/gha-ci#37

Blocked by silverstripe/silverstripe-asset-admin#1281

Fix https://github.com/silverstripe/recipe-content-blocks/runs/7457942258?check_suite_focus=true#step:12:67
1) DNADesign\Elemental\Tests\Legacy\GraphQL\AddElementToAreaMutationTest::testAddingBlocksInOrder TypeError: Argument 1 passed to GraphQL\Type\Definition\ResolveInfo::__construct() must be of the type array, object given, called in /home/runner/work/recipe-content-blocks/recipe-content-blocks/vendor/silverstripe/graphql/tests/Fake/FakeResolveInfo.php on line 39

webonyx/graphql v0.12.6 is used on 3.7 of graphql, v14 is used in 3.8

Copying what is done here - https://github.com/silverstripe/silverstripe-elemental/blob/4.9/tests/GraphQL/FakeResolveInfo.php#L15

@GuySartorelli GuySartorelli merged commit 45078da into silverstripe:3.7 Jul 22, 2022
@GuySartorelli GuySartorelli deleted the pulls/3.7/fakeresolveinfo2 branch July 22, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants