Merge pull request #287 from creative-commoners/pulls/5/protect-hooks

API Set extension hook implementation visibility to protected
silverstripe · May 21, 2024 · f9b2cac · f9b2cac
2 parents 0cb1319 + a7fc4ee
commit f9b2cac
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/Extensions/FluentLinkExtension.php b/src/Extensions/FluentLinkExtension.php
@@ -9,7 +9,7 @@
 
 class FluentLinkExtension extends Extension
 {
-    public function updateCMSFields(FieldList $fields)
+    protected function updateCMSFields(FieldList $fields)
     {
         $this->removeTabsWithFluentGridfields($fields);
     }

diff --git a/src/Extensions/UsedOnTableExtension.php b/src/Extensions/UsedOnTableExtension.php
@@ -10,7 +10,7 @@
 
 class UsedOnTableExtension extends Extension
 {
-    public function updateUsageAncestorDataObjects(array &$ancestorDataObjects, DataObject $dataObject): void
+    protected function updateUsageAncestorDataObjects(array &$ancestorDataObjects, DataObject $dataObject): void
     {
         if (!is_a($dataObject, FileLink::class)) {
             return;

diff --git a/src/Models/Link.php b/src/Models/Link.php
@@ -186,7 +186,7 @@ public function getVersionedState(): string
         return 'unversioned';
     }
 
-    public function onBeforeWrite(): void
+    protected function onBeforeWrite(): void
     {
         // Ensure a Sort value is set and that it's one larger than any other Sort value for
         // this owner relation so that newly created Links on MultiLinkField's are properly sorted

diff --git a/tests/php/Extensions/ExternalLinkExtension.php b/tests/php/Extensions/ExternalLinkExtension.php
@@ -7,7 +7,7 @@
 
 class ExternalLinkExtension extends DataExtension implements TestOnly
 {
-    public function updateDefaultLinkTitle(&$defaultLinkTitle): void
+    protected function updateDefaultLinkTitle(&$defaultLinkTitle): void
     {
         $defaultLinkTitle = sprintf('External Link: %s', $this->owner->getURL());
     }