-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BUGFIX Fixing date/datetime handling in MSSQLDatabase
Fixing the date type to actually be "date", and not "datetime" so that values are returned as "Y-m-d" for dates, and not "Y-m-d H:i:s". Additionally, fixing a case where using the mssql functions would return strange datetime formats. We need the datetime field values in Y-m-d H:i:s. To get this working, we need to inspect the field type when retrieving rows from the database and re-format the datetime value at this point. This is done in MSSQLQuery::nextRecord()
- Loading branch information
Sean Harvey
committed
Jun 12, 2012
1 parent
4962524
commit a4c269b
Showing
3 changed files
with
48 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
<?php | ||
class MSSQLDatabaseQueryTest extends SapphireTest { | ||
|
||
public static $fixture_file = 'MSSQLDatabaseQueryTest.yml'; | ||
|
||
protected $extraDataObjects = array( | ||
'MSSQLDatabaseQueryTestDataObject' | ||
); | ||
|
||
public function testDateValueFormatting() { | ||
$obj = $this->objFromFixture('MSSQLDatabaseQueryTestDataObject', 'test-data-1'); | ||
$this->assertEquals('2012-01-01', $obj->TestDate, 'Date field value is formatted correctly (Y-m-d)'); | ||
} | ||
|
||
public function testDatetimeValueFormatting() { | ||
$obj = $this->objFromFixture('MSSQLDatabaseQueryTestDataObject', 'test-data-1'); | ||
$this->assertEquals('2012-01-01 10:30:00', $obj->TestDatetime, 'Datetime field value is formatted correctly (Y-m-d H:i:s)'); | ||
} | ||
|
||
} | ||
class MSSQLDatabaseQueryTestDataObject extends DataObject implements TestOnly { | ||
|
||
public static $db = array( | ||
'TestDate' => 'Date', | ||
'TestDatetime' => 'SS_Datetime' | ||
); | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
MSSQLDatabaseQueryTestDataObject: | ||
test-data-1: | ||
TestDate: 2012-01-01 | ||
TestDatetime: 2012-01-01 10:30:00 | ||
|