Several fixes for 4.0 compatibility. #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unneeded omnipay/tests dependency. Updated routes with proper namespace. Fixed deprecations in PaymentDevelopmentAdmin. Added PaymentDevelopmentAdmin as a dev task via `dev.yml` Fixed several upgrading issues. Added silverstripe/versioned as dev-dependency. Fixed unit-tests.
bummzack
force-pushed
the
fix-unit-tests
branch
from
b75029e
to
8e3e8f9
Compare
bummzack
force-pushed
the
fix-unit-tests
branch
from
3ab6fb6
to
961ae45
Compare
bummzack
force-pushed
the
fix-unit-tests
branch
from
961ae45
to
d43b629
Compare
Remove echo statement in PaymentService…
Use codecov to upload coverage.
Replaced deprecated `assertDOSContains` method.
bummzack
force-pushed
the
fix-unit-tests
branch
from
c9e3650
to
aed5cd6
Compare
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
========================================
Coverage ? 84.8%
Complexity ? 523
========================================
Files ? 22
Lines ? 1481
Branches ? 0
========================================
Hits ? 1256
Misses ? 225
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated methods.
Remove unneeded omnipay/tests dependency.
Updated routes with proper namespace.
Fixed deprecations in PaymentDevelopmentAdmin.
Added PaymentDevelopmentAdmin as a dev task via
dev.ymlFixed several upgrading issues.
Added silverstripe/versioned as dev-dependency.
Fixed unit-tests.