ENH: Provide a way to conditionally disable the raygun handler. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmatt
requested changes
Oct 26, 2021
There was a problem hiding this comment.
Thanks @GuySartorelli, this looks good. If you're providing this, could you please show an example of overriding this in the README (e.g. I presume you're calling Config::modify() within your BuildTask?)
Other than that, the change looks good to me.
GuySartorelli
force-pushed
the
feat/disable-handler
branch
from
8e2a5dd
to
5aac929
Compare
GuySartorelli
force-pushed
the
feat/disable-handler
branch
from
5aac929
to
23d190b
Compare
|
Commenting in case it's not clear: Requested changes have been made. |
|
@GuySartorelli please rebase on |
There are situations where it may be useful to have the `SS_RAYGUN_APP_KEY` environment variable set without automatically sending all exceptions to Raygun.
GuySartorelli
force-pushed
the
feat/disable-handler
branch
from
e1b9d27
to
c82e998
Compare
|
@michalkleiner I've rebased on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are situations where it may be useful to have the
SS_RAYGUN_APP_KEYenvironment variable set without automatically sending all exceptions to Raygun.In particular, we have a use case where we don't want errors sent to raygun in our test and QA environments usually, but we want to be able to run a
BuildTaskto trigger an exception that does get sent to raygun in those environments as a quick test that changes we have made do what we expect them to in regards to error monitoring.