Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH support raygun4php SDK v2 #67

Merged
merged 2 commits into from Dec 25, 2021

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Nov 29, 2021

Fixes #59

This PR provides support for raygun4php sdk V2 while allowing anyone who for whatever reason might want/need to stay on sdk V1 (e.g. super old PHP versions) to keep up to date with this module.

The only breaking changes that I can see for sdk V2 vs V1 are in the constructor so I think this should be safe.
I have tried both versions of the SDK with this PR and have had no issues with either.

graze/monolog-extensions is no longer maintained. See graze/monolog-extensions#32.
Pulling this code into this repository directly is the first step in updating this module to supporting Raygun's PHP SDK v2.
@GuySartorelli GuySartorelli marked this pull request as ready for review November 29, 2021 05:04
@GuySartorelli GuySartorelli changed the title ENH Grab relevant code from unmaintained graze/monolog-extensions. ENH support raygun4php SDK v2 Nov 29, 2021
@GuySartorelli
Copy link
Member Author

GuySartorelli commented Dec 8, 2021

@robbieaverill @brynwhyman Any chance at having some eyes across this? It would be great if we could have this merged and tagged before/with the SS 4.10 release. That will make it easy to update this module at the same time as updating framework in our sites.

There's also some new filtering functionality about to get which just got a stable tag in SDK v2 so it'd be great to be able to take advantage of that.

@brynwhyman
Copy link

Hey @GuySartorelli I'm no longer working with Silverstripe so can't as easily find folks to help sorry. @madmatt perhaps this is something you could please help with?

@madmatt
Copy link
Member

madmatt commented Dec 25, 2021

This looks good to me, thanks and Merry Christmas @GuySartorelli! 🎄

@madmatt madmatt merged commit b4c965f into silverstripe:master Dec 25, 2021
@madmatt
Copy link
Member

madmatt commented Dec 25, 2021

New release 3.5.0 now includes this change along with 3 others from you, thanks again @GuySartorelli! 🎉

@GuySartorelli
Copy link
Member Author

Thank you! A great Christmas present 😁

@GuySartorelli GuySartorelli deleted the enh/php-sdk-v2 branch December 25, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for Raygun PHP SDK v2 when it is released
3 participants