Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fix for invalid argument type provided to writeError() #72

Merged

Conversation

chrispenny
Copy link
Collaborator

@chrispenny chrispenny commented Apr 27, 2023

Fixes #71
Closes #71

Tested on a live environment. I'm no longer getting instances of the errors from #71

@chrispenny chrispenny marked this pull request as ready for review April 27, 2023 03:30
@chrispenny
Copy link
Collaborator Author

Fix has been running over the weekend on our environment. There have been no new instances of this error.

I won't wait for a review on this, given the small size, and the fact that I've now seen it working.

@chrispenny chrispenny merged commit 028d482 into silverstripe:master Apr 30, 2023
@chrispenny chrispenny deleted the pulls/invalid-argument-error branch April 30, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant