Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Recommend installation of spamprotection #966

Merged

Conversation

maxime-rainville
Copy link
Contributor

Parent issue

#954

@sunnysideup sunnysideup mentioned this pull request May 12, 2020
1 task
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
Copy link

@brynwhyman brynwhyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the important part is to direct the reader to the other module. Following install steps in this readme will increase the chances of missing steps (like choosing a verification module)

readme.md Outdated Show resolved Hide resolved
Co-authored-by: Bryn Whyman <bryn.whyman@silverstripe.com>
@maxime-rainville
Copy link
Contributor Author

I've committed Bryn's suggestion.

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@emteknetnz emteknetnz merged commit f27045b into silverstripe:5 May 26, 2020
@maxime-rainville maxime-rainville deleted the pulls/5/suggest-spam-protection branch May 27, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants