FIX: Track deletions correctly #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sminnee
commented
Jul 6, 2020
| if (!$record) { | ||
| return null; | ||
| } | ||
| if ($record->hasExtension(Versioned::class) && $record->isArchived()) { | ||
|
|
||
| $refetched = DataObject::get_by_id($record->baseClass(), $record->ID); |
There was a problem hiding this comment.
It's not clear to me why we need to re-fetch the record here, and can't simply return the existing record in all cases.
|
@unclecheese would be good to get this reviewed if you have chance. |
Because $obj->ID is set to 0 on a deleted record, this broke the existing snapshot creation. Relies on silverstripe/silverstripe-versioned#280, without which deletions are logged as another creation.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because $obj->ID is set to 0 on a deleted record, this broke the existing
snapshot creation.
Relies on silverstripe/silverstripe-versioned#280,
without which deletions are logged as another creation.
Fixes #33