Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Add a querystring hash to fonts #47

Merged

Conversation

emteknetnz
Copy link
Member

Fixes silverstripe/silverstripe-admin#1064

https://www.npmjs.com/package/file-loader#options

admin/client/src/styles/_fonts.scss

image

admin/client/dist/styles/bundle.css

Before
image

After
image

@emteknetnz
Copy link
Member Author

Note, to get #iefix and #silverstripe hashes to stay in compiled css, can add this

Change

    {
      loader: 'resolve-url-loader',
    },

To

    {
      loader: 'resolve-url-loader',
      options: {
        keepQuery: true
      },
    },

However I think this makes zero difference in practice because this is for very old browsers. IE11 still works fine as is, so I'd rather not introduce this as it has a slight chance of creating a regression somewhere else

Copy link
Member

@Cheddam Cheddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.6.0 Regression / Font icons break with cache
2 participants