feat: more lambda config options #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonard-henriquez
changed the title
jakthom
reviewed
Dec 10, 2023
| @@ -4,6 +4,16 @@ variable "aws_region" { | |||
| default = "us-east-1" | |||
| } | |||
|
|
|||
| variable "aws_access_key" { | |||
There was a problem hiding this comment.
Let's use named profiles (with profile) instead of aws_access_key and aws_secret_access_key. Static creds are increasingly 💀 .
https://registry.terraform.io/providers/hashicorp/aws/latest/docs#profile
There was a problem hiding this comment.
Fixed it 👌
|
Looks good - one small fix re: |
leonard-henriquez
added a commit
that referenced
this pull request
Dec 12, 2023
* v0.18.0 * feat: extend cors (#578) * fix: cors not applied to all routes (#577) * feat: improve schema read (#576) * feat: collect ip fingerprint and better tstamp (#575) * feat: log schema metadata (#574) * feat: more lambda config options (#573) * fet: more lambda config options * chore: remove unused var * review --------- Co-authored-by: Léonard Henriquez <leonard@topo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new features to make the Lambda terraform config more versatile: