Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #1245

Merged
merged 1 commit into from Oct 27, 2022
Merged

Upgrade dependencies #1245

merged 1 commit into from Oct 27, 2022

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Oct 27, 2022

Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The axios update apparently broke the tests. This is odd as I didn't have any issues when updating in Braggy. Perhaps this is due to the monorepo set-up ?

@axelboc
Copy link
Contributor Author

axelboc commented Oct 27, 2022

Probably because we use our own Jest config based on ts-jest. axios is now compiled to ESM, so we need to tell Jest to transform it to CommonJS. Also fixed an issue in rollup.config.js files where the ./vite.config imports were missing the JS extension.

@axelboc axelboc merged commit 0e6dcd7 into main Oct 27, 2022
@axelboc axelboc deleted the deps branch October 27, 2022 10:03
@axelboc
Copy link
Contributor Author

axelboc commented Oct 27, 2022

Actually, it's because in Braggy's tests, we mock the API file that imports axios. In H5Web's tests, we don't mock axios imports -- we just don't make any requests with it since we use the MockProvider.

@axelboc axelboc mentioned this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants