Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements combined LineVis: Line and glyphs #145

Merged
merged 1 commit into from
May 20, 2020
Merged

Implements combined LineVis: Line and glyphs #145

merged 1 commit into from
May 20, 2020

Conversation

loichuder
Copy link
Member

@loichuder loichuder commented May 19, 2020 •
edited
Loading

image

  • Removes the dropdrown to choose glyphs (Added sprite-based glyphs to LineVis #143) to avoid cluttering the interface. The glyph is forced to a cross.
  • Adds a button group to choose between Line, Points and Line+Points. Implementation and design to be discussed.

PS: Tests are failing cause we have two tabs named Line. This might change with the implementation of ButtonGroup.

@loichuder loichuder linked an issue May 20, 2020 that may be closed by this pull request
[Line] Glyphs for data points #121
Closed
axelboc
axelboc approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@axelboc axelboc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super 👍

@loichuder loichuder merged commit b39ca84 into master May 20, 2020
@loichuder loichuder deleted the combined-line branch May 20, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelboc axelboc axelboc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Line] Glyphs for data points
2 participants
@loichuder @axelboc