Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CSV export for Matrix vis #739

Merged
merged 3 commits into from
Jul 7, 2021
Merged

Implement CSV export for Matrix vis #739

merged 3 commits into from
Jul 7, 2021

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Jul 2, 2021

Part of #35

This is the simplest step I could think of to make some data exportable from H5Web. The Matrix vis now shows a button to download the current slice as CSV.

image

image

@axelboc axelboc requested a review from loichuder July 2, 2021 11:32
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The export does not work for 1D data so you can either change the throw condition to reflect this or change the algo to handle 1D data.

src/h5web/toolbar/MatrixToolbar.tsx Outdated Show resolved Hide resolved
src/h5web/toolbar/MatrixToolbar.tsx Show resolved Hide resolved
src/h5web/vis-packs/core/matrix/utils.ts Outdated Show resolved Hide resolved
src/h5web/vis-packs/core/matrix/utils.ts Show resolved Hide resolved
@axelboc axelboc merged commit 3e0350f into main Jul 7, 2021
@axelboc axelboc deleted the matrix-csv-export branch July 7, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants