Add "Export" menu to toolbars with CSV/NPY/TIFF exports #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelboc
commented
Nov 30, 2021
loichuder
approved these changes
Dec 1, 2021
|
Marking the PR as "waiting" until you find the time to implement the TIFF endpoint in H5Grove. |
The demo is now requesting the tentative implementation at silx-kit/h5grove#54. You can give it a try |
|
I'm getting a black TIFF file with the right dimensions, so I assume it works! |
|
We'll just have to update the compatibility comment in |
This was referenced Dec 3, 2021
Add controls to export dataset or slice to NPY and CSV
axelboc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #35
The feature detection is actually quite simple: I've discovered that an abstract class can have an optional method! So if the provider implements the method, it is defined; otherwise it isn't. This means that the toolbar can just check if
getTiffUrlis defined to decide whether to show the export button.I've provided a tentative implementation of the method for H5Grove. It returns a URL of this form:
https://<h5grove.url>/tiff/?<axios-params>&path=/foo&selection=0:,:. Up to H5Grove to then respond at this URL with the TIFF data and the correctContent-typeHTTP header (image/tiff).Update
I've merged #890 into this branch, so now it includes CSV and NPY exports as well.