Updated LZ4 filter #172
Merged
Updated LZ4 filter #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t20100
commented
May 18, 2022
Comment on lines
-341
to
+349
| H5_DLL herr_t H5free_memory(void *mem); | ||
| H5_DLL void *H5allocate_memory(size_t size, hbool_t clear); | ||
| // Special case | ||
| // H5_DLL herr_t H5free_memory(void *mem); | ||
| // H5_DLL void *H5allocate_memory(size_t size, hbool_t clear); | ||
| H5_DLL void *H5resize_memory(void *mem, size_t size); | ||
|
|
||
| // Filters should use malloc/free | ||
| #define H5free_memory(mem) free(mem) | ||
| #define H5allocate_memory(size, clear) malloc(size) | ||
|
|
There was a problem hiding this comment.
The new version of the LZ4 filter use H5allocate_memory/H5free_memory.
From what I understand this should not be used here in filters. No other filter is using this, even filters in https://github.com/HDFGroup/hdf5_plugins/ use malloc/free.
So I defined macros to use malloc/free instead.
|
OK |
vasole
approved these changes
May 18, 2022
This was referenced Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the LZ4 compression filter and the lz4 library it uses.
It also adds the license from dectris since the code comes from there.
closes #158