Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests with jupyterhub v4 and update lint-test.yml #100

Merged
merged 2 commits into from
May 15, 2023
Merged

Fix tests with jupyterhub v4 and update lint-test.yml #100

merged 2 commits into from
May 15, 2023

Conversation

t20100
Copy link
Member

@t20100 t20100 commented May 12, 2023 •
edited
Loading

This PR:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/setup-python@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

@t20100 t20100 added this to the Next release milestone May 12, 2023
@t20100 t20100 requested a review from loichuder May 12, 2023 08:01
@t20100 t20100 changed the title Update lint-test.yml Fix tests with jupyterhub v4 and update lint-test.yml May 12, 2023
t20100
t20100 commented May 12, 2023
View reviewed changes
test/utils.py Show resolved Hide resolved
loichuder
loichuder approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@loichuder loichuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@t20100 t20100 merged commit ea16f10 into main May 15, 2023
@t20100 t20100 deleted the update-ci-config branch May 15, 2023 07:15
@t20100 t20100 modified the milestones: 6.0.0, 7.0.0 Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loichuder loichuder loichuder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@t20100 @loichuder