Fixed GPU resource parsing and pydantic support #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t20100
commented
Aug 22, 2023
| :returns: (GPU resource template, number of GPUs) or None if the resource is not a GPU. | ||
| :raises ValueError: If parsing failed. | ||
| """ | ||
| for resource in generic_resources.split(","): |
There was a problem hiding this comment.
SLURM "generic resources" can be a comma-separated list of many different things, here we only pick the first gpu with a correct syntax.
loichuder
approved these changes
Aug 22, 2023
Co-authored-by: Loïc Huder <42204205+loichuder@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 issues:
GPU resource parsing failures when there is more than one GPU or other resources (Related to issue spawner.py fails to parse when multiple gpu types in same node #104). Some unit tests were added for the parsing. As it stands, there is no real support for multiple GPUs, this PR only avoids to raise an exception and pick the first GPU in the list (this can be overridden in the config).
An error occuring with current latest version of
pydantic(v2.2.1):