Add "preview" support of Singularity images #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a support of singularity images.
The command to start singularity can be tuned in the config.
The requirements on the singularity image is that batchspawner and jupyterhub (and obviously jupyter/jupyterlab) are available in the container and are in the PATH.
There is a convenient flow in the current implementation: one can pass options (e.g.,
--nvto enable nvidia GPU support and--bindto "mount" directories in the container, like/data) as space separated along with the "environment path".In a final version, I would avoid that, either with the right options in the "singularity_cmd" or through specific inputs in the UI, but for a "preview" feature it's good to have flexibility.
I didn't advertise the support of it in the interface on purpose to keep it as a beta feature for now.