Move checks back to options_from_form
#83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t20100
commented
Jan 26, 2023
|
|
||
| if "root_dir" in self.user_options: | ||
| self.notebook_dir = self.user_options["root_dir"] | ||
| self.__update_options(options, partition_info) |
There was a problem hiding this comment.
Updating options here to request partition_info only once since this calls an external tool and might be costly.
t20100
commented
Jan 26, 2023
loichuder
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of PR #71 where I miss-understood something: There is no problem to have a async
options_from_form, so this reworks the code to make all checks there so the error messages are propagated.