ElideLabel: Fix API inherited from QLabel #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume it is working with QtDesigner. |
t20100
reviewed
Aug 31, 2022
There was a problem hiding this comment.
To me, it's not worth breaking the API beyond replacing the properties by methods.
- tests are failing due to: https://github.com/silx-kit/silx/blob/master/src/silx/gui/plot/actions/histogram.py#L67
vallsv
force-pushed
the
elided-api
branch
2 times, most recently
from
e3dd4d1
to
aa39d76
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the ElideLabel API inherited from QLabel.
For consistency and interoperability purpose.
Closes #3641
Changelog: