Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silx.io.dictdump: Removed dicttoh5 overwrite_data argument #3806

Merged
merged 1 commit into from
May 9, 2023

Conversation

t20100
Copy link
Member

@t20100 t20100 commented May 5, 2023

This PR removes dicttoh5's overwrite_data argument that is deprecated since v0.15.0.

Do you think it's OK, or it's best to keep maximum compatibility here?

related to #3754

@t20100 t20100 added this to the 2.0.0 milestone May 5, 2023
@t20100 t20100 requested a review from woutdenolf May 5, 2023 12:31
Copy link
Contributor

@woutdenolf woutdenolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t20100 t20100 merged commit 3acafe4 into silx-kit:main May 9, 2023
@t20100 t20100 deleted the remove-dicttoh5-overwrite_data-arg branch May 9, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants