Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added profile to compare image #3845

Merged
merged 11 commits into from
Jun 12, 2023
Merged

Added profile to compare image #3845

merged 11 commits into from
Jun 12, 2023

Conversation

vallsv
Copy link
Contributor

@vallsv vallsv commented Jun 8, 2023 •
edited
Loading

Closes #3761

Screenshot from 2023-06-08 18-46-01

Changelog:

  • Added profile to compare image

@t20100 t20100 added this to the 2.0.0 milestone Jun 9, 2023
@vallsv vallsv changed the title Draft: Added profile to compare image Added profile to compare image Jun 12, 2023
@vallsv vallsv requested a review from t20100 June 12, 2023 09:19
@vallsv vallsv mentioned this pull request Jun 12, 2023
Merged
@t20100
Copy link
Member

t20100 commented Jun 12, 2023

BTW, CI fails on appveyor because of change in pytest v7.3.2 .
Here is a fix: ccdc13b (in PR #3842)

@vallsv
Copy link
Contributor Author

vallsv commented Jun 12, 2023

BTW, CI fails on appveyor because of change in pytest v7.3.2 . Here is a fix: ccdc13b (in PR #3842)

Could you create a PR with it, only?

@vallsv vallsv merged commit 1ec7898 into silx-kit:main Jun 12, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t20100 t20100 t20100 left review comments

Assignees
No one assigned
Labels
enhancement ready to merge
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

CompareImages: Fail with some modes + RGBA data
2 participants
@vallsv @t20100