Tests and continuous integration: Fixed issues and updated CI configuration #4149
+331
−411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t20100
commented
Jul 12, 2024
pyproject.toml
Outdated
Comment on lines
16
to
28
| python_files = [ | ||
| "test/test*.py", | ||
| "test/Test*.py", | ||
| ] | ||
| python_classes = "Test" | ||
| python_functions = "test" | ||
| filterwarnings = [ | ||
| "error", | ||
| # note the use of single quote below to denote "raw" strings in TOML | ||
| 'ignore:tostring\(\) is deprecated. Use tobytes\(\) instead\.:DeprecationWarning:OpenGL', | ||
| 'ignore:Jupyter is migrating its paths to use standard platformdirs:DeprecationWarning', | ||
| ] |
There was a problem hiding this comment.
This was only taken into account when running tests from source directory... so all test files not starting with test_ where skipped when running from silx.test.run_tests....
Also raising errors on warnings was not enabled all the time.
Comment on lines
+175
to
+178
| test_module.run_tests( | ||
| module=None, | ||
| args=[normalize_option(p) for p in sys.argv[1:] if p != "--installed"], | ||
| ) |
src/silx/test/__init__.py
Outdated
Comment on lines
59
to
83
| cmd = [ | ||
| sys.executable, | ||
| "-m", | ||
| "pytest", | ||
| f"--rootdir={silx.__path__[0]}", | ||
| "--verbosity", | ||
| str(verbosity), | ||
| # Handle warning as errors unless explicitly skipped | ||
| "-Werror", | ||
| "-Wignore:tostring() is deprecated. Use tobytes() instead.:DeprecationWarning", | ||
| "-Wignore:Jupyter is migrating its paths to use standard platformdirs:DeprecationWarning", | ||
| ] + list(args) | ||
|
|
||
| if module is not None: | ||
| # Retrieve folder for packages and file for modules | ||
| imported_module = importlib.import_module(module) | ||
| cmd.append( | ||
| imported_module.__path__[0] | ||
| if hasattr(imported_module, "__path__") | ||
| else imported_module.__file__ | ||
| ) | ||
|
|
||
| return subprocess.run(cmd, check=False).returncode |
There was a problem hiding this comment.
run_tests.py now uses this function.
It should be the only way to start silx tests to make sure to use consistent config
Comment on lines
-327
to
-334
| if qt.BINDING == "PySide6": | ||
| # PySide has no qWait, provide a replacement | ||
| timeout = int(ms) | ||
| endTimeMS = int(time.time() * 1000) + timeout | ||
| qapp = qt.QApplication.instance() | ||
| while timeout > 0: | ||
| qapp.processEvents(qt.QEventLoop.AllEvents, timeout) | ||
| timeout = endTimeMS - int(time.time() * 1000) |
There was a problem hiding this comment.
With PySide6, QTest.qWait exists...
| """ | ||
|
|
||
| class _Signals(qt.QObject): | ||
| class Signal(qt.QObject): |
There was a problem hiding this comment.
Reworking the signaling from thread to avoid a segmentation fault
.github/workflows/ci.yml
Outdated
Comment on lines
151
to
153
| if [ ${{ runner.os }} == 'Windows' ]; then | ||
| export WITH_GL_TEST=False | ||
| fi |
There was a problem hiding this comment.
Disable OpenGL tests on Windows for now: some of the tests fails and this needs more investigation...
t20100
force-pushed
the
ci-windows
branch
3 times, most recently
from
8d3e670
to
252045f
Compare
for all test file names
t20100
force-pushed
the
ci-windows
branch
2 times, most recently
from
3f9f1d0
to
960610f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
<Module or Topic>: <Action> <Summary>(see contributing guidelines)This PR aims at fixing tests errors/seg fault occuring in CI.
It does not fix all randomly occuring errors. For example, errors due to
os.unlinkfailing because a file is accessed by another process under Windows are not fixed.It also updates the CI configuration, mainly to also run GUI tests on Windows with github actions (without the tests that require OpenGL for now).