Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2: support for multiple SNMP transports #7

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Version 2: support for multiple SNMP transports #7

merged 1 commit into from
Aug 4, 2020

Conversation

grongor
Copy link
Collaborator

@grongor grongor commented Jun 1, 2020

No description provided.

@grongor grongor requested a review from simPod June 1, 2020 14:52
@grongor grongor force-pushed the v2 branch 2 times, most recently from 7e34530 to ec3ef77 Compare June 1, 2020 14:55
Copy link
Owner

@simPod simPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exceptions are missing verb in name or something that indicates what actually is the issue

src/Exception/EndOfMibReached.php Outdated Show resolved Hide resolved
src/Exception/GeneralException.php Show resolved Hide resolved
src/Exception/NoSuchInstanceExists.php Outdated Show resolved Hide resolved
src/Exception/NoSuchObjectExists.php Outdated Show resolved Hide resolved
src/Helpers/OidStripper.php Show resolved Hide resolved
src/Helpers/OidStripper.php Outdated Show resolved Hide resolved
src/Helpers/SingleValue.php Outdated Show resolved Hide resolved
src/Transport/SnmpClient.php Outdated Show resolved Hide resolved
@grongor grongor requested a review from simPod June 7, 2020 10:25
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
src/Transport/ApiSnmpClient.php Outdated Show resolved Hide resolved
src/Transport/CliSnmpClient.php Show resolved Hide resolved
src/Transport/CliSnmpClient.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@grongor grongor requested a review from simPod June 8, 2020 11:16
src/Helpers/OidStripper.php Outdated Show resolved Hide resolved
src/Helpers/ValueGetter.php Outdated Show resolved Hide resolved
tests/Transport/ValueParserTest.php Outdated Show resolved Hide resolved
tests/Transport/ApiSnmpClientTest.php Outdated Show resolved Hide resolved
@grongor grongor force-pushed the v2 branch 5 times, most recently from 20103b6 to 028bab8 Compare July 2, 2020 12:55
Copy link
Owner

@simPod simPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jeste na tu traitu se chci mrknout vic

src/Helpers/ValueGetter.php Outdated Show resolved Hide resolved
src/Transport/FallbackSnmpClient.php Show resolved Hide resolved
Also move to Github Actions and Coveralls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants