-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve coverage #2 #209
Improve coverage #2 #209
Conversation
It seems that the code coverage is tagged as decreased because it uses the number of lines as metrics. With the If you want to review this change in its own PR to better see the coverage improvements of the other commits, let me know and I'll split the PR. |
Sorry for the late reply :) this looks great I'll update the branch and see if that solves the clippy complaining |
Seems update was not enough :) can you address the clippy issues and then we can merge this :D |
I had a hard time finding the clippy warnings the previous commits added. So I fixed most of the clippy warnings (most of them by This one is also not addressed by this commit
|
a253039
to
b73ad3d
Compare
b73ad3d
to
ce857d2
Compare
👍 awesome, I think leaving that out for now is fine. the |
This PR is based on the PR #207