Improve coverage3 #210
Merged
Improve coverage3 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Licenser
approved these changes
Nov 3, 2021
dvermd
force-pushed
the
improve_coverage3
branch
from
6a547eb
to
d9f6f4a
Compare
|
This looks great :) I think only thing missing is that in |
dvermd
force-pushed
the
improve_coverage3
branch
from
1a52464
to
18a2f12
Compare
Licenser
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the PR #209 and adds more tests for #57
I added 2 methods to the API to be able to trigger some of the deserializing code.
If these methods should not go in the API, the corresponding code can be removed