Use the dom::parser internal loaded_bytes buffer as a tmp padded buffer when realloc_if_needed #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bobergj The fuzzer appears to have found an issue, can you have a look? ../include/simdjson/dom/parser-inl.h:112:17: runtime error: null pointer passed as argument 1, which is declared to never be null
310
/usr/include/string.h:44:28: note: nonnull attribute specified here
311
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../include/simdjson/dom/parser-inl.h:112:17 in |
lemire
reviewed
Mar 25, 2021
| } | ||
| _loaded_bytes_capacity = len; | ||
| } | ||
| std::memcpy(static_cast<void *>(loaded_bytes.get()), buf, len); |
There was a problem hiding this comment.
This seems to be unsafe in the sense that a pointer could be null.
There was a problem hiding this comment.
Yes, this could indeed happen if the input buffer was empty (len == 0). Fixed in new commit.
It could be that the parse file code path (not modified by this PR) has a similar issue when a zero byte file is parsed, not sure.
There was a problem hiding this comment.
It could be that the parse file code path (not modified by this PR) has a similar issue when a zero byte file is parsed, not sure.
I will add a test for that specifically.
bobergj
force-pushed
the
use-internal-buffer-as-tmp
branch
from
9455d04
to
10977a4
Compare
|
This looks pretty good. |
|
Marked for 1.0 release. |
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the dom::parser internal loaded_bytes buffer as a tmp padded buffer when realloc_if_needed is true.
Motivation: