Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement all Tournament v4 and Tournament Stub v4 endpoints #40

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

simivar
Copy link
Owner

@simivar simivar commented Oct 27, 2020

Implement all Tournament v4 and Tournament Stub v4 endpoints: #19 & #18

@codecov-io
Copy link

codecov-io commented Oct 27, 2020

Codecov Report

Merging #40 into main will decrease coverage by 0.12%.
The diff coverage is 95.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #40      +/-   ##
============================================
- Coverage     97.36%   97.23%   -0.13%     
- Complexity      669      712      +43     
============================================
  Files            93       99       +6     
  Lines          2273     2463     +190     
============================================
+ Hits           2213     2395     +182     
- Misses           60       68       +8     
Impacted Files Coverage Δ Complexity Δ
src/Riot/API.php 0.00% <0.00%> (ø) 29.00 <4.00> (+4.00)
src/Riot/API/Version4/Tournament.php 100.00% <100.00%> (ø) 6.00 <6.00> (?)
src/Riot/API/Version4/TournamentStub.php 100.00% <100.00%> (ø) 4.00 <4.00> (?)
src/Riot/Collection/LobbyEventDTOCollection.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
src/Riot/Connection.php 100.00% <100.00%> (ø) 19.00 <5.00> (+4.00)
src/Riot/DTO/LobbyEventDTO.php 100.00% <100.00%> (ø) 5.00 <5.00> (?)
src/Riot/DTO/LobbyEventDTOWrapperDTO.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/Riot/DTO/TournamentCodeDTO.php 100.00% <100.00%> (ø) 15.00 <15.00> (?)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9dc03e...745b289. Read the comment docs.

@simivar simivar merged commit c91467a into main Oct 27, 2020
@simivar simivar deleted the feature/all-tournament-endpoints branch October 27, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants