-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implem call to NOW() #3007
Implem call to NOW() #3007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, and congratulations on your first contribution!
The change looks good to me, but we need a test to verify that it keeps working. You could add one to this file. Tests there have access to the eval
function which takes an expression and runs it on the postgres server. So you could write a test calling await eval(now())
and then verifies that the time we get back is close to DateTime.now()
in Dart.
Thanks for the message, I've tried to implement tests but I can't run the tests locally But I got this error on all the tests
|
Hm I've never considered that this would be broken on Windows, sorry. I don't have a Windows machine at hand, but can you check whether replacing But also could this be a firewall or an outdated Docker desktop version? A friend using Windows tell me he can access containers via |
I've tried, I don't have |
Did you have a chance to revisit this yet? I'm also happy to help with the test if you can't get the configuration to work locally. |
Hey, |
Ah yes that's a tricky one, I've fixed it by giving an explicit type to use with This looks good to me now, if the PR is ready from your point of view I can merge and release it. |
Oooh ! thanks I'll be how to do it next time haha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem! And the custom types stuff is pretty tricky, as you can see I also got it wrong with the genRandomUuid()
function.
Thanks again for your contribution!
Hello o/
This is my first open source contribution.
I wanted to implement a function to call the
NOW()
function in postgres.Problem:
Try to understand how to have createdAt with a default value
Resolution:
Create this function in my server, but could be in the lib