Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Extension Won't Load Anymore #74

Closed
DaveChild opened this issue May 28, 2016 · 5 comments
Closed

Extension Won't Load Anymore #74

DaveChild opened this issue May 28, 2016 · 5 comments

Comments

@DaveChild
Copy link

Used to work fine for me, but now the icon doesn't show in the address bar any more. There's an error in the Chrome console as well:

Uncaught SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode - content.js:3308

The line is:

let userId;
@DaveChild
Copy link
Author

DaveChild commented May 28, 2016

This is Chrome Version 47.0.2526.106 (64-bit) on Ubuntu, if that makes a difference.

@simon-weber
Copy link
Owner

Huh, sorry about that. I'll add back the strict mode declarations. I removed them because eslint complained and it worked when I tested in my chrome, haha.

@simon-weber
Copy link
Owner

Ah, yeah, it looks like that's 49 specific according to http://blog.chromium.org/2016/02/chrome-49-beta-css-custom-properties.html:

Improved ECMAScript 2015 support
The ES2015 specification (ES6) is a major update to JavaScript that allows developers to write application logic that is more legible, powerful, and memory efficient. [...] The latest version of Chrome also makes block-level constructs such as class and let available outside of strict mode.

Looks like it might be time for me to have some basic automated tests across different version of chrome, huh?

@simon-weber
Copy link
Owner

Ok, 1.5.2 is up with the fix. Sorry again, and thanks for letting me know!

@DaveChild
Copy link
Author

Thanks, all working again now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants