Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run e2e in CI #118

Merged
merged 6 commits into from
Apr 19, 2024
Merged

chore: Run e2e in CI #118

merged 6 commits into from
Apr 19, 2024

Conversation

simondotm
Copy link
Owner

No description provided.

@simondotm simondotm mentioned this pull request Apr 19, 2024
7 tasks
@simondotm
Copy link
Owner Author

Reminds me that I should break the CI out into separate jobs for build/lint/test

@tommy9
Copy link
Collaborator

tommy9 commented Apr 19, 2024

Doing a bit of searching around the error message, I came across mention of the X virtual frame buffer (xvfb) tool. There are a few example on GitHub https://github.com/search?q=ci.yml+Xvfb+path%3A%2F%5E.github%5C%2Fworkflows%5C%2F%2F&type=code&p=1 although not exactly matching. It might be as simple as prepending xvfb-run before the test task i.e. xvfb-run npm run e2e, although some of the examples do sudo apt-get install xvfb so perhaps that is needed too.

@simondotm
Copy link
Owner Author

@tommy9 great scott! It worked 🎩 🧙

@tommy9
Copy link
Collaborator

tommy9 commented Apr 19, 2024

That's awesome! Really nice to have. I need to make more tests now 😀

I can run the server unit tests too, will just need to clear out the copious amounts of console logging I left in for debugging purposes then will try to add to the CI.

@simondotm simondotm changed the title chore: Try e2e in CI chore: Run e2e in CI Apr 19, 2024
@simondotm simondotm merged commit f025b94 into master Apr 19, 2024
5 checks passed
@simondotm simondotm deleted the chore/e2e-ci branch April 19, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants