feat: update to support axios 1.x #1418
Conversation
Updated the following packages too: - LRUCache - jest - ts-jest - prettier - typescript
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1418 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 1 -1
Lines 167 166 -1
Branches 45 44 -1
=========================================
- Hits 167 166 -1
☔ View full report in Codecov by Sentry. |
|
Np, will try and take a look today.
Sent from Samsung Mobile on O2
Sent from Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Simone Busoli ***@***.***>
Sent: Thursday, September 7, 2023 10:58:00 PM
To: simoneb/axios-hooks ***@***.***>
Cc: Mark Hebden ***@***.***>; Author ***@***.***>
Subject: Re: [simoneb/axios-hooks] feat: update to support axios 1.x (PR #1418)
@simoneb commented on this pull request.
Thanks a lot for this contribution, much appreciated! I never got around to doing the whole upgrade as it had too many moving pieces. There are a couple of ling warnings, would you mind fixing those as well?
—
Reply to this email directly, view it on GitHub<#1418 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAUTUFFIXX2ZTESIT2RRBTLXZI7ORANCNFSM6AAAAAA4HKI32I>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Looks like the cancel token is deprecated in favour of abort controller from |
|
Absolutely, can you do it within this PR? |
|
Not sure if you get notified or not but that's in now too :) |
package.json
Outdated
| "test": "tsd && jest --no-cache" | ||
| }, | ||
| "dependencies": { | ||
| "@babel/runtime": "7.22.11", | ||
| "dequal": "2.0.3", | ||
| "lru-cache": "^8.0.0" | ||
| "lru-cache": "^10.0.1" | ||
| }, | ||
| "peerDependencies": { | ||
| "axios": ">=0.24.0", |
There was a problem hiding this comment.
you'll need to update this too. unless we know that it's axios 1.5 and up, we should try to keep it as low as possible, e.g. 1.x
There was a problem hiding this comment.
Good spot! Thats now updated to >=1.0.0
There was a problem hiding this comment.
Thanks. Nope notifications for commits are not sent, so thanks for letting me know 👍
Updated the following packages too: