Implement Container.remove method #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it "works" on win32 in the sense of removing the element correctly, but it gives a null pointer error next time the window is focused. I'm taking a look at it now. |
|
Functionality now works on win32 as well, the crash was due to the window storing the removed control as the "focused element". This PR is ready for review/merge. |
|
Thanks! I can't remember why I commented it out. I will test if there are any issues with the 'remove'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
container.remove. Fixes the commented out code fromnigui.nimand implements the GTK backend for it. It is unclear to me why the code innigui.nimwas commented out, so if there is additional context please let me know.