cf/bs/bse/is don't show child accounts if there is an intervening account of another type

[simonmichael]

Reported by scara. Eg

account a         ; type:L
account a:aa      ; type:X
account a:aa:aaa  ; type:L

2021-01-01
    (a)                                            1
    (a:aa)                                         1
    (a:aa:aaa)                                     1

$ hledger bs
Balance Sheet 2021-01-01

             || 2021-01-01 
=============++============
 Assets      ||            
-------------++------------
-------------++------------
             ||            
=============++============
 Liabilities ||            
-------------++------------
 a           ||         -1 
-------------++------------
             ||         -1 
=============++============
 Net:        ||          1 

It should show a:aa:aaa as well (compare bal type:L and accounts --types. These commands need to be updated to use the newer account type queries.

hledger/hledger-lib/Hledger/Data/Journal.hs

Lines 481 to 510 in b32b130

	-- | Get a query for accounts of the specified types in this journal.
	-- Account types include:
	-- Asset, Liability, Equity, Revenue, Expense, Cash, Conversion.
	-- For each type, if no accounts were declared with this type, the query
	-- will instead match accounts with names matched by the case-insensitive
	-- regular expression provided as a fallback.
	-- The query will match all accounts which were declared as one of
	-- these types (by account directives with the type: tag), plus all their
	-- subaccounts which have not been declared as some other type.
	--
	-- This is older code pre-dating 2022's expansion of account types.
	journalAccountTypeQuery :: [AccountType] -> Regexp -> Journal -> Query
	journalAccountTypeQuery atypes fallbackregex Journal{jdeclaredaccounttypes} =
	let
	declaredacctsoftype :: [AccountName] =
	concat $ mapMaybe (`M.lookup` jdeclaredaccounttypes) atypes
	in case declaredacctsoftype of
	[] -> Acct fallbackregex
	as -> And $ Or acctnameRegexes : if null differentlyTypedRegexes then [] else [ Not $ Or differentlyTypedRegexes ]
	where
	-- XXX Query isn't able to match account type since that requires extra info from the journal.
	-- So we do a hacky search by name instead.
	acctnameRegexes = map (Acct . accountNameToAccountRegex) as
	differentlyTypedRegexes = map (Acct . accountNameToAccountRegex) differentlytypedsubs
	differentlytypedsubs = concat
	[subs | (t,bs) <- M.toList jdeclaredaccounttypes
	, t `notElem` atypes
	, let subs = [b | b <- bs, any (`isAccountNamePrefixOf` b) as]
	]

[simonmichael]

Fixed by #1923.