Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.32: hledger import corrupts .latest files #2125

Closed
simonmichael opened this issue Dec 7, 2023 · 1 comment
Closed

1.32: hledger import corrupts .latest files #2125

simonmichael opened this issue Dec 7, 2023 · 1 comment
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. import regression A backwards step, indicating a weakness in our QA. We don't like these.

Comments

@simonmichael
Copy link
Owner

simonmichael commented Dec 7, 2023 •
edited

In 1.32, hledger import FILE1 FILE2 ... seems to write all files' new transaction dates to all of the .latest* files. These are what import uses to remember which transactions it has already processed, so corrupting them will likely disrupt subsequent imports.

I consider this is a fairly serious regression, because it could be tedious to recover from if you do a lot of importing. Please avoid importing from multiple files at once with hledger-1.32; this will be fixed by 1.32.1.

Importing from one file at a time is safe (but it won't interleave transactions by date). Eg:

bad: hledger import a.csv b.csv
good: hledger import a.csv; hledger import b.csv
@simonmichael simonmichael added A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. import regression A backwards step, indicating a weakness in our QA. We don't like these. labels Dec 7, 2023
@simonmichael simonmichael changed the title hledger-1.32 import with multiple input files corrupts the .latest files, forgetting import state hledger-1.32 import with multiple input files corrupts the .latest files Dec 7, 2023
simonmichael added a commit that referenced this issue Dec 7, 2023
@simonmichael
fix:import: save each file's latest dates, separately (#2125)
c0481e6
simonmichael added a commit that referenced this issue Dec 7, 2023
@simonmichael
fix:import: save each file's latest dates, separately (#2125)
c6a580f
@simonmichael simonmichael changed the title hledger-1.32 import with multiple input files corrupts the .latest files hledger-1.32 import corrupts .latest files Dec 7, 2023
@simonmichael
Copy link
Owner Author

Fixed by 1.32.1.

@simonmichael simonmichael changed the title hledger-1.32 import corrupts .latest files 1.32: hledger-1.32 corrupts .latest files Dec 16, 2023
@simonmichael simonmichael changed the title 1.32: hledger-1.32 corrupts .latest files 1.32: hledger import corrupts .latest files Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. import regression A backwards step, indicating a weakness in our QA. We don't like these.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonmichael