balance assertion errors should show a more accurate line number

[simonmichael]

Currently they show the line number where the transaction starts. Better to show the line number of the posting with the failing assertion.

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[jeevcat]

I was thinking about having a look at this issue as something easy to get me started contributing. However, as far as I can tell, there are currently no line numbers being printed for balance assertion errors?
I'm looking here and at the following strings at 417 and 419.

[simonmichael]

Great. That's actually a different error (unbalanced transaction). Here's the balance assertion error.

[simonmichael]

I notice it says column 0 which looks a little odd, I wonder how hard it would be to show just the line number, or (gold plated version) the actual column of the = sign.

[jeevcat]

I have this working now, but it only finds the column using the output of postingAsLines or show transaction. However, this isn't always the same as what is written in a journal file.

I can see that I can get the transaction's 1-based position in the input stream from a Transaction. How can I access the current input stream from the checkBalanceAssertion function?

[simonmichael]

To do it robustly I guess we'd have to save the position of the balance assertion during parsing, similar to Transaction.tsourcepos. Perhaps: type BalanceAssertion = Maybe (Amount, GenericSourcePos) data Posting = Posting {... pbalanceassertion :: BalanceAssertion ...}

[simonmichael]

PS if you think it's worth the trouble. Or we could just not show a column number.

[jeevcat]

Can we go with type BalanceAssertion = (Maybe Amount, Maybe GenericSourcePos) instead?

In some places I'm unable to populate the source position easily - like in Equity.hs and CSV parsing.

[simonmichael]

I was wondering how tsourcepos handles that.. it uses nullsourcepos.