Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hledger sets nix enabled to false by default #712

Closed
cdepillabout opened this issue Mar 4, 2018 · 7 comments · Fixed by #713
Closed

hledger sets nix enabled to false by default #712

cdepillabout opened this issue Mar 4, 2018 · 7 comments · Fixed by #713
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. platform:nix

Comments

@cdepillabout
Copy link

cdepillabout commented Mar 4, 2018

The stack.yaml file in the root of the repo sets nix.enabled to false.

This makes builds on NixOS fail by default.

Normally, to use stack on NixOS, you add nix.enabled to ~/.stack/config.yaml. However, with nix.enabled set to false in hledger's stack.yaml, the settings in ~/.stack/config.yaml are ignored.

Ideally, nix.enabled would not be set in hledger's stack.yaml file so that stack would fall back to the nix.enabled setting specified in ~/.stack/config.yaml.

@simonmichael simonmichael added platform:nix A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. labels Mar 4, 2018
@simonmichael
Copy link
Owner

Thanks for the report. @efx, any thoughts ? I'm not finding discussion of 6bd86f9.

@simonmichael
Copy link
Owner

I assume this affects http://hledger.org/download.html -> B, C but not A.

simonmichael added a commit that referenced this issue Mar 4, 2018
@cdepillabout
Copy link
Author

I think it was added here, but there doesn't seem to be any discussion as to why nix.enabled is set to false (instead of just not specified).

@ghost
Copy link

ghost commented Mar 5, 2018

IIRC, we set this to false so that the stack installer wouldn't default to using nix, but you could opt in. based on what @cdepillabout points out, I think it is safe to remove and just document that preferred approach:

Ideally, nix.enabled would not be set in hledger's stack.yaml file so that stack would fall back to the nix.enabled setting specified in ~/.stack/config.yaml.

@ghost ghost self-assigned this Mar 5, 2018
@ghost ghost added the in progress label Mar 5, 2018
@simonmichael
Copy link
Owner

What docs are needed ? What were the circumstances under which stack installer would default to using nix ?

@ghost
Copy link

ghost commented Mar 5, 2018

Maybe they are not needed. I think you need to have the nix enabled set to true in your per user stack config. Otherwise, you have to pass --nix to stack install for it to be enabled.

@simonmichael
Copy link
Owner

Ok, the current PR sounds good to me. Thanks!

@ghost ghost removed the in progress label Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-BUG Something wrong, confusing or sub-standard in the software, docs, or user experience. platform:nix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants