Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce lenses for ReportOpts, ReportSpec, CliOpts, etc. #1545

Closed
wants to merge 12 commits into from
Closed

Introduce lenses for ReportOpts, ReportSpec, CliOpts, etc. #1545

wants to merge 12 commits into from

Commits on Jul 13, 2021

  1. lib,cli,ui,web: Rename fields of ReportSpec to be consistent with Rep… 

    …ortOpts, CliOpts, etc.

rsOpts -> reportopts_
rsToday -> reportday_
rsQuery -> query_
rsQueryOpts -> queryopts_
    @Xitian9
    Xitian9 committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    471d4d5 View commit details
    Browse the repository at this point in the history

  2. lib,cli: Rename some fields of ReportOpts and InputOpts to avoid name… 

    … clashes.

ReportOpts:
color_ -> showcolor_
drop_ -> droplevels_
empty_ -> showempty_
transpose_ -> transposetable_
InputOpts:
anon_ -> anonymise_
    @Xitian9
    Xitian9 committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    22071c7 View commit details
    Browse the repository at this point in the history

  3. lib,cli,web: Create a Template Haskell helper for removing trailing u… 

    …nderscores

to make lenses. Then make classy lenses for BalancingOpts.

Also rename balancingOpts -> defbalancingopts.
    @Xitian9
    Xitian9 committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    7da4e8f View commit details
    Browse the repository at this point in the history

  4. lib: Make classy lenses for InputOpts.

    @Xitian9
    Xitian9 committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    372a3d8 View commit details
    Browse the repository at this point in the history

  5. lib: Add classy lenses for ReportOpts, ReportSpec.

    @Xitian9
    Xitian9 committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    cb2f1ab View commit details
    Browse the repository at this point in the history

  6. cli,web: Add classy lenses for CliOpts. 

    Also hide some imports in hledger-web to avoid name clashes.
    @Xitian9
    Xitian9 committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    34e6e0a View commit details
    Browse the repository at this point in the history

  7. lib,cli,web: Refactor to use BalancingOpts, InputOpts, ReportSpec, an… 

    …d CliOpts lenses.
    @Xitian9
    Xitian9 committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    1c608f8 View commit details
    Browse the repository at this point in the history

  8. ui: Refactor code to eliminate requirement for change_ in UIOpts.

    @Xitian9
    Xitian9 committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    aa734bc View commit details
    Browse the repository at this point in the history

  9. ui: Add classy lenses for UIOpts, and lenses for UIState. 

    Implement a few code simplifications to reduce boilerplate and take
advantage of the new lenses.
    @Xitian9
    Xitian9 committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    11fede0 View commit details
    Browse the repository at this point in the history

  10. ui: Refactor to eliminate UIOpts.

    @Xitian9
    Xitian9 committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    1032b2b View commit details
    Browse the repository at this point in the history

  11. lib,cli,ui: Refactor to simplify code by using lenses.

    @Xitian9
    Xitian9 committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    3b90ae1 View commit details
    Browse the repository at this point in the history

  12. lib: Write out ReportSpec lenses and classes by hand, rather than usi… 

    …ng TemplateHaskell.
    @Xitian9
    Xitian9 committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    80a618f View commit details
    Browse the repository at this point in the history