feat: ui: Add a dark theme #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted a theme with roughly the same degree of colour as the default but which was easier on my eyes late at night. Signed-off-by: Jonathan Dowland <jon@dow.land>
|
Nice! I've also opened #2168, in case you have any thoughts. Dark theme seems very dark and low contrast here (dark grey text on black background). Is it a bit too extreme for the prominent "dark" name ? |
|
Added as is for now. Thanks! |
Great, thanks! I've got some more work to raise that renames default->light and uses the fixed colour palette, and I may make some further change suggestions to the dark theme too. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted a theme with roughly the same degree of colour as the default but which was easier on my eyes late at night.
(Also; I wanted to build hledger on my new machine to get back to #2158, and this was an itch to scratch)