add option for bandshift_dict #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgarrido
approved these changes
May 5, 2023
| fg_components, | ||
| fg_params, | ||
| fg_norm=None, | ||
| band_shift_dict=None): |
There was a problem hiding this comment.
I think band_shift_params is a better name
pspipe_utils/best_fits.py
Outdated
| @@ -246,6 +251,8 @@ def get_foreground_dict(ell, external_bandpass, fg_components, fg_params, fg_nor | |||
|
|
|||
| fg_norm: dict | |||
| the foreground normalisation. By default, {"nu_0": 150.0, "ell_0": 3000, "T_CMB": 2.725} | |||
| band_shift: dict | |||
There was a problem hiding this comment.
then here it is band_shift_dict
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
- Coverage 16.14% 15.40% -0.74%
==========================================
Files 11 11
Lines 1220 1220
==========================================
- Hits 197 188 -9
- Misses 1023 1032 +9
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.