-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added iBootbar agent with MIB and added set function to snmp.py #306
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @davidvng! It's looking good, I have some suggestions for the structure, some questions, and documentation requests inline below.
One thing we're still missing is an Agent Reference Page. That'll go in socs/docs/agents/
and should be added to the index socs/docs/index.rst
under the "Agent Reference" section. You can then try building the docs locally, which I usually do to check formatting.
This reverts commit 76c8338.
for more information, see https://pre-commit.ci
I also just added the MIB file to our pre-commit runs flake8 and is catching a few unused imports. Please remove those as well. See output here: https://results.pre-commit.ci/run/github/186511668/1656001941.ccW0D6oWQ3uLcZUGv8WYrw (This is the "Details" on the pre-commit line under the checks at the end of this PR page.) |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I handled conflict in ibootbar.rst
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! I have a couple questions still, and some clarification is needed on the session.data format.
EDIT: I pushed some small changes to the docstrings and docs page, as well as adding the docs page to the index file.
for more information, see https://pre-commit.ci
Description
Added a set function to snmp.py to handle any set commands used in agent scripts.
Added new agent directory with Dockerfile, agent python script, and MIB (in sub-directory mibs).
The iBootbar agent contains 1 process and 4 tasks:
Motivation and Context
Initial iBootbar agent PR.
Closes #63.
How Has This Been Tested?
Tested with iBootbar equipment in the lab. Ran each individual task and verified the changes done on the system. Tested the main process by verifying data is seen on OCS web and Grafana.
Types of changes
Checklist:
develop
branch.