Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out better pattern for custom feed titles #6

Closed
simonw opened this issue Nov 30, 2019 · 5 comments
Closed

Figure out better pattern for custom feed titles #6

simonw opened this issue Nov 30, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Nov 30, 2019

https://www.niche-museums.com/browse/feed.atom?_feed_title=Niche+Museums

Gotta be a better way. Since browse/feed here is a canned query defined in metadata.json pulling in the canned query title would be good. Will have to update the plugin hook to do that though.
@simonw simonw added the enhancement New feature or request label Nov 30, 2019
@simonw
Copy link
Owner Author

simonw commented Nov 30, 2019

See simonw/datasette#581

@simonw simonw mentioned this issue Dec 26, 2019
Closed
@simonw
Copy link
Owner Author

simonw commented May 28, 2020

I'm going to remove the current hacky ?_feed_title=... mechanism and release this as 1.0.

@simonw
Copy link
Owner Author

simonw commented May 28, 2020

... actually no, that mechanism stays - it's useful for assigning titles to feeds created by arbitrary SQL queries.

@simonw
Copy link
Owner Author

simonw commented May 28, 2020

I'm going to use datasette.metadata() to find the title of the canned query. This isn't yet documented: simonw/datasette#780

@simonw simonw closed this as completed in 64de6b0 May 28, 2020
@simonw
Copy link
Owner Author

simonw commented May 28, 2020

Documented here: https://github.com/simonw/datasette-atom/blob/64de6b0a3863f80738327d9f1c6f8e4c56d73587/README.md#using-a-canned-query

simonw added a commit to simonw/museums that referenced this issue May 28, 2020
@simonw
Upgrade to datasette-atom 0.6
3054100 
This means /brose/feed.atom has a title defined in metadata.yaml

Takes advantage of simonw/datasette-atom#6
simonw added a commit to simonw/til that referenced this issue May 29, 2020
@simonw
Upgrade to datasette-atom 0.6
b65aa29 
Take advantage of simonw/datasette-atom#6
@simonw simonw mentioned this issue May 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw