Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a maximum of ten maps, require 'click to see map' for more than that #16

Closed
simonw opened this issue Jan 20, 2021 · 2 comments
Closed

Show a maximum of ten maps, require 'click to see map' for more than that #16

simonw opened this issue Jan 20, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Jan 20, 2021

It feels bad when this plugin renders 1,000 maps because someone ran a big custom query.

Could resolve this by only loading the first ten results, and using a grey square for others which can be clicked to load the map for it.
@simonw simonw added the enhancement New feature or request label Jan 20, 2021
simonw added a commit that referenced this issue Jan 20, 2021
@simonw
Only load first ten maps, refs #16
8a04cd7
@simonw
Copy link
Owner Author

simonw commented Jan 20, 2021

loading-maps

@simonw
Copy link
Owner Author

simonw commented Jan 20, 2021

I'm going to add a setting for this.

@simonw simonw changed the title Idea: show a maximum of ten maps, require 'click to see map' for more than that Show a maximum of ten maps, require 'click to see map' for more than that Jan 20, 2021
@simonw simonw closed this as completed in 98b58e1 Jan 20, 2021
simonw added a commit that referenced this issue Jan 20, 2021
@simonw
Tests for default_maps_to_load, refs #16
7e31c0a
simonw added a commit that referenced this issue Jan 20, 2021
@simonw
Release 0.7
444a3b1 
Refs #16
simonw added a commit to simonw/calands-datasette that referenced this issue Jan 20, 2021
@simonw
datasette-leaflet-geojson>=0.7
20077a3 
No need for a default page size any more, since the new
version only loads ten maps initially.

simonw/datasette-leaflet-geojson#16
@simonw simonw mentioned this issue Feb 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw