Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dumb XSS hole #2

Closed
simonw opened this issue Aug 9, 2021 · 3 comments
Closed

Dumb XSS hole #2

simonw opened this issue Aug 9, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@simonw
Copy link
Owner

simonw commented Aug 9, 2021

select 'select ''<script>alert(/ohno/)</script>'''

https://latest-with-plugins.datasette.io/fixtures?sql=select+%27select+%27%27%3Cscript%3Ealert%28%2Fohno%2F%29%3C%2Fscript%3E%27%27%27

Due to this code:

return markupsafe.Markup('<a href="{}">{}</a>'.format(path, value))

@simonw simonw added the bug Something isn't working label Aug 9, 2021
@simonw simonw closed this as completed in 233a07e Aug 9, 2021
simonw added a commit that referenced this issue Aug 9, 2021
simonw added a commit to simonw/latest-datasette-with-all-plugins that referenced this issue Aug 9, 2021
@simonw
Copy link
Owner Author

simonw commented Aug 9, 2021

@simonw
Copy link
Owner Author

simonw commented Aug 9, 2021

I'm going to delete the 0.1 release from PyPI just to make absolutely sure no-one ever installs it by accident.

@simonw
Copy link
Owner Author

simonw commented Aug 9, 2021

I chose to "delete" rather than "yank" because I'm confident no-one has pinned to version 0.1 of this library anywhere. https://blog.piwheels.org/new-features-deletion-yanking-and-more/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant